autoload_once fix when using Pathnames on ruby 1.9 #2673
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecation warning 3 0 fix
Fix load path test 3 0
…et a better trace without it
…t have validation errors
… YAML 1.1 compatibility
…thod 'prerequisites' for nil:NilClass (from rspec)
This fixes rake for me in RefineryCMS.
3 0 stable jruby jdom fixes
Loading AS encoding.
3-0-stable schema dumper test fix
…nd db schema version
Fix rails#2368 (3-0-stable)
Fix ArgumentError in ActiveSupport::Cache::CacheStore.read_multi
… time is 00:50 GMT+1. Without the quoting, the YAML parser would parse this as 00:50 UTC, into the local time of 01:50 GMT+1. Then, it would get written into the database in local time as 01:50. When it came back out the UTC date from the database and the UTC date of two weeks ago would be compared. The former would be 23:50, and the latter would be 00:50, so the two dates would differ, causing the assertion to fail. Quoting it prevents the YAML parser from getting involved.
Fix ActiveSupport::Gzip under Ruby 1.8.7. Closes rails#2416
Porting changes on form_tag method signature to 3-0-stable
XSS attacks. Thanks Sascha Depold for the report.
* 3-0-10: bumping rails to 3.0.10 properly subsituting bad utf8 characters Tags with invalid names should also be stripped in order to prevent XSS attacks. Thanks Sascha Depold for the report. prevent sql injection attacks by escaping quotes in column names Properly escape glob characters. bumping to 3.0.10.rc1 more changelog updates updating CHANGELOGs
Use mysql_creation_options inside rescue block
Prototype rails.js fixes for 3-0-stable
Under ruby 1.9.2 -
"/var/log".starts_with?(Pathname.new("/var")) # => false
so setting config.autoload_once_paths with Pathnames would not work
|
a PR that went bad? |
|
Uhh... yeah, no kidding. Let me try reapplying to master & trying again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heya,
I ran into a fun issue on ruby 1.9 where my autoload_once stuff was geting reloaded on each request. Turns out that under 1.9, "/var/log".start_with?(Pathname("/var")) returns false, and I was using :
config.autoload_once_paths += [config.root.join('lib')]
Converting to strings fixed the issue. The attached patch just calls to_s on the autoload_once pathnames in load_once_path?, which is the only problem I've discovered when using Pathnames instead of regular strings.
Any thoughts?
-Jonathan