fix https://github.com/rails/rails/issues/2947 (with testcase) #2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g and Array values to indicate recipients.
- The initializer is called `set_autoload_paths`, not `set_autoload_path`. See https://github.com/rails/rails/blob/master/railties/lib/rails/engine.rb#L506
yield(:unspecified_block) actually returns true even if :unspecified_block never exists. This means you can't use the form yield(:unspecified_block) or yield.
…ns that it doesn't force Action Controller / Active Record to load, but it doesn't fail if they have already loaded. Thanks @josevalim for the hint.
XSS attacks. Thanks Sascha Depold for the report.
… whitespace from security.textile
Regexps have a construct to express alternation of characters, which is character classes. In addition to being the most specific idiom to write this pattern, it reads better without the backslashes. Also, it is better not to use a capture if none is needed. As a side-effect of these changes, the gsub is marginally faster, but speed is not the point of this commit.
This reverts commit aa1d1e4. Conflicts: activesupport/lib/active_support/core_ext/module/delegation.rb activesupport/test/core_ext/module_test.rb
This reverts commit aa1d1e4. Conflicts: activesupport/lib/active_support/core_ext/module/delegation.rb activesupport/test/core_ext/module_test.rb
Debug assets by default in development and test environments
Find in batches changelog
Fix AssetNotPrecompiledError behavior
Add entry about Asset behaviour fix to ActionPack ChangeLog
Need to make sure about order here.
Never return stored content from content_for when a block is given
Remove unused config variable from test.rb template
Backport rails#2789 to 3-1-stable
…ct_options!` `ActiveSupport::OrderedHash` is actually a subclass of the hash, so it does make sense that it should be extractable from the array list.
…ered_hash Make `ActiveSupport::OrderedHash` extractable when using `Array#extract_options!`
Fix bad options order in AR::Migration::CommandRecorder#invert_rename_index
Last orders the records by id
Uglifier bump
…s they have been failing intermittently for a long while due to what appears to be a Ruby bug. If anyone has the skills/expertise/time to debug this, please speak to the Travis guys.
…_broken_yaml_exception in fixtures_test.rb on Ruby 1.8.7.
…ion#inverse_updates_counter_cache?. Fixes rails#2755, where a counter cache could be decremented twice as far as it was supposed to be.
…ough model should not be included in the association scope. (We're already excluding includes.) Fixes rails#2834.
config.action_controller.perform_caching isn't used anymore in asset pipeline
Fix double slash at start of paths when mounting an engine at the root.
|
sorry, miss operation. |
|
@kennyj Wrong pull request! You have included 250+ commits. Please open with appropriate branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.