Improve railties generators tests #30164
Conversation
bogdanvlviv
force-pushed
the
improve-railties-generators-tests
branch
2 times, most recently
from
1344b97
to
a96b558
Compare
| @@ -106,11 +106,28 @@ def test_generating_test_files_in_full_mode_without_unit_test_files | |||
| end | |||
| end | |||
|
|
|||
| def test_generating_adds_dummy_app_in_full_mode_without_sprockets | |||
| run_generator [destination_root, "-S", "--full"] | |||
| def test_generator_if_skip_sprockets_is_given | |||
There was a problem hiding this comment.
after remove --full option
- test_generating_adds_dummy_app_in_full_mode_without_sprockets
+ test_generating_adds_dummy_app_without_sprockets| def test_generating_adds_dummy_app_in_full_mode_without_sprockets | ||
| run_generator [destination_root, "-S", "--full"] | ||
| def test_generator_if_skip_sprockets_is_given | ||
| run_generator [destination_root, "--skip-sprockets"] |
There was a problem hiding this comment.
Should we keep the --full option?
There was a problem hiding this comment.
No, this test hasn't had any relations to --full option, so this is extra here.
| end | ||
| end | ||
|
|
||
| def test_requires_if_skip_railties |
There was a problem hiding this comment.
test_default_frameworks_are_required_when_others_are_removed
| assert_no_file "test" | ||
| assert_no_file "test/test_helper.rb" | ||
| assert_directory "spec/dummy" | ||
| assert_file "spec/dummy/config/application.rb", /#\s+require\s+["']rails\/test_unit\/railtie["']/ |
There was a problem hiding this comment.
We don't need to check this if it is checked in other place.
There was a problem hiding this comment.
It isn't checked in another place, we need to check it.
A generation of plugin --skip-test has the more complicated case than a generation of app.
If rails plugin new name_plugin --skip-test and --dummy-path is test/dummy(default value the same), it woun't create a dummy app.
(we have condition for creation dummy app: options[:skip_test].blank? || options[:dummy_path] != "test/dummy"),
so it isn't possible to test # require "rails/test_unit/railtie" for existence in config/application.rb,
but we can reach it by rails plugin new name_plugin --skip-test --dummy-path=spec/dummy
|
|
||
| def test_action_cable_is_removed_from_frameworks_if_skip_action_cable_is_given | ||
| run_generator [destination_root, "--skip-action-cable"] | ||
| assert_file "test/dummy/config/application.rb", /#\s+require\s+["']action_cable\/engine["']/ |
There was a problem hiding this comment.
Does this test pass only with the first commit?
There was a problem hiding this comment.
No, the test fails.
Only
assert_file "test/dummy/config/application.rb", /#\s+require\s+["']action_cable\/engine["']/ passes, it looks strange
There was a problem hiding this comment.
run_generator [destination_root, "--skip-action-cable"]
assert_file "test/dummy/config/application.rb", /#\s+require\s+["']action_cable\/engine["']/I think i got why it passes on master,
test/dummy/ is generated by Rails::Generators::AppGenerator with filtered options,
then we replace some files in test/dummy/ with all options
https://github.com/rails/rails/blob/master/railties/lib/rails/generators/rails/plugin/plugin_generator.rb#L106-L112
Next example doesn't pass on master, because these files are generated by Rails::Generators::AppGenerator with filtered options, https://github.com/rails/rails/blob/master/railties/lib/rails/generators/rails/plugin/plugin_generator.rb#L88-L104
run_generator [destination_root, "--skip-action-cable"]
assert_no_file "test/dummy/config/cable.yml"
assert_no_file "test/dummy/app/assets/javascripts/cable.js"
assert_no_directory "test/dummy/app/channels"
assert_file "Gemfile" do |content|
assert_no_match(/redis/, content)
endit only will pass if add :skip_action_cable to PASSTHROUGH_OPTIONS. If don't pass :skip_action_cable to PASSTHROUGH_OPTIONS , these files will be always generated because skip_action_cable is false by default https://github.com/rails/rails/blob/master/railties/lib/rails/generators/app_base.rb#L55
| @@ -1,3 +1,7 @@ | |||
| * Add `--skip-action-cable` option to the plugin generator. | |||
There was a problem hiding this comment.
Could you squash this commit with the commit that added the option?
Improve app generator tests. Ensure that generation `config/application.rb` is correct. Ensure that generation `config/application.rb` is correct.
bogdanvlviv
force-pushed
the
improve-railties-generators-tests
branch
from
86d2e50
to
8cc5a6e
Compare
|
Really good PR! 👏 |
Improve plugin generator tests
Improve app generator tests
Ensure that generation
config/application.rbis correct.Related to #30123
--skip-action-cablepass throughsrails plugin new(i found this when i was improving tests)Also, this PR will prevent making mistakes like: #30101 (comment)
r? @rafaelfranca