Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dummy_app configuration #30123

Merged
merged 1 commit into from
Aug 8, 2017

Conversation

yhirano55
Copy link
Contributor

@yhirano55 yhirano55 commented Aug 7, 2017

Summary

Though it requires components same as actual application, it seems that wrong requiring components and orders.

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@rafaelfranca rafaelfranca merged commit 507f3ef into rails:master Aug 8, 2017
@yhirano55 yhirano55 deleted the fix_dummy_app_configuration branch August 8, 2017 22:11
bogdanvlviv added a commit to bogdanvlviv/rails that referenced this pull request Aug 10, 2017
Improve app generator tests.

Ensure that generation `config/application.rb` is correct.

Ensure that generation `config/application.rb` is correct.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants