Do not enable disabled elements for XHR redirects #31441
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
|
Related PR: turbolinks/turbolinks-rails#28 |
|
Sorry I have no clue who to assign to this. I am not the right person to review this. |
mrhead
force-pushed
the
rails-ujs-xhr-redirects
branch
from
75d5702
to
41c3a72
Compare
mrhead
force-pushed
the
rails-ujs-xhr-redirects
branch
from
41c3a72
to
5994ee8
Compare
|
I've just updated this PR with tests for rails-ujs. |
mrhead
force-pushed
the
rails-ujs-xhr-redirects
branch
2 times, most recently
from
dc4428f
to
58d22c5
Compare
mrhead
force-pushed
the
rails-ujs-xhr-redirects
branch
from
58d22c5
to
8e07711
Compare
|
@rafaelfranca I've added tests and updated the PR summary to better demonstrate the issue. Could you please review it? Thank you! |
|
@rafaelfranca Thank you! |
|
@mrhead Do you know when new release 5.2.2 is planned? This merge request fixes our issue and we'd like to use it. Currently we can install rails gem from |
|
Ok, it looks like the rails side of things was merged, but the turbolinks gem has yet to release a new version to include turbolinks/turbolinks-rails#28 :( |
|
This should be released with Rails 6.
…On Fri, 10 May 2019 at 13:09, Max Lielje ***@***.***> wrote:
Am I correct in that this is actually *not* part of 5.2.2 or 5.2.3? I
just updated to 5.2.3 and I still see the old behavior.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#31441 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD7RB36NHZ72RP5ODO7EADPUVJVVANCNFSM4EIHBJJQ>
.
|
Summary
Fixes #29473.
Depends on: turbolinks/turbolinks-rails#28
Before
After