Remove useless argument #315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SQLite3 tests still pass, I can't see why this would be a problem if they aren't really used. |
This reverts commit 057412c.
…imit which doesn't cause issues on sqlite
…oller::TestCase#process since ActionDispatch::Http::Parameters#encode_params will force encoding on all params strings (when using an encoding aware Ruby), dup all strings passed into process. This prevents modification of params passed in and, more importantly, doesn't barf when a frozen string is passed thanks and high fives to kinsteronline
This is useful in situations like model unit tests and the occasional rake task to backfill old data.
…hierarchy. Last call wins.
|
I'm closing this pull request since somehow got dirty. |
matthewd
added a commit
that referenced
this pull request
Apr 24, 2018
Wrap group_by sql with a subquery for limiting rows in Oracle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The +name+ argument on the #columns method is useless, no implementation of this method makes use of it.
I removed the argument since it only creates confusion.