Include test helpers in ActionDispatch::IntegrationTest #33849
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @georgeclaghorn (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
| require "active_job" | ||
| require "action_mailer" | ||
|
|
||
| include ActiveJob::TestHelper |
There was a problem hiding this comment.
This need to be the opposite. It should be the Active Job and Action Mailer railtie that includes those modules in the action_dispatch_integration_test for the case were your app don't use one of those frameworks.
There was a problem hiding this comment.
That makes a lot of sense. I was struggling about loading both libraries in the ActionDispatch railtie. I updated this patch according to your suggestions. Thanks!
As @dhh brings up, the point of `ActionDispatch::IntegrationTest` is to allow users to test the integration of all the pieces called by a controller. Asserting about the emails and jobs queued is part of that task. This commit includes the `ActionMailer::TestHelper` and `ActiveJob::TestHelper` modules when the ActionMailer and ActiveJob railties are initialized respectively.
ricardotk002
force-pushed
the
include-helpers-action-dispatch-integration-test
branch
from
9039abb
to
64a9759
Compare
|
❤️ |
Since these changes related to the public API, I think we should add changelog entries. Related to rails#33838, rails#33849
…33849 Add changelog entries for #33849 [ci skip]
In Rails 5.x, having this setting in config/environments/test.rb ``` config.active_job.queue_adapter = :inline ``` was enough to tell Active Job to **run** the jobs during test. In Rails 6, the behavior has changed because of rails/rails#33849 that uses the Test Adapter by default. Therefore we need to specify *which* tests to run with InlineAdapter.
ricardotk002
deleted the
include-helpers-action-dispatch-integration-test
branch
Summary
Fixes #33838
As @dhh brings up, the point of
ActionDispatch::IntegrationTestis toallow users to test the integration of all the pieces called by a
controller. Asserting about the emails and jobs queued is part of that
task.
In this commit, I use the
action_dispatch_integration_testhook to includethe
ActionMailer::TestHelperandActiveJob::TestHelpermoduleswhen the ActionMailer and ActiveJob railties are initialized respectively.