Improve enqueue_retry.active_job
message
#33972
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #33751
enqueue_retry.active_job
instrumentation was added tothe
retry_on
method, then #33897 moved the instrumentation toretry_job
method in order to ensure that this method publish
enqueue_retry.active_job
notification too.
See related discussion #33751 (comment)
Since
enqueue_retry.active_job
moved toretry_job
, there is no guaranteethat payload of
enqueue_retry.active_job
would have:error
.See test
LoggingTest#test_enqueue_retry_logging_on_retry_job
asexample of that case.
Related to #33897 (comment)
I think we can improve notification of
enqueue_retry.active_job
:event.payload[:error]
, then publish like"Retrying RescueJob in 3 seconds." only.
event.payload[:wait]
isnil
, then publish"Retrying RescueJob in 0 seconds." instead of "Retrying RescueJob in nil seconds."
event.payload[:error]
, then publish"Retrying RescueJob in 3 seconds, due to a DefaultsError.".
error
toinfo.
Also, this commit removes part of messages - "The original exception was #{ex.cause.inspect}."
of
enqueue_retry.active_job
,retry_stopped.active_job
, anddiscard.active_job
since Ihaven't found it useful. Please let me know whether you agree with that?
r? @kaspth