Improve enqueue_retry.active_job message

[bogdanvlviv]

Since #33751 enqueue_retry.active_job instrumentation was added to
the retry_on method, then #33897 moved the instrumentation to retry_job
method in order to ensure that this method publish enqueue_retry.active_job
notification too.
See related discussion #33751 (comment)

Since enqueue_retry.active_job moved to retry_job, there is no guarantee
that payload of enqueue_retry.active_job would have :error.
See test LoggingTest#test_enqueue_retry_logging_on_retry_job as
example of that case.

Related to #33897 (comment)

I think we can improve notification of enqueue_retry.active_job:

• If there is no event.payload[:error], then publish like
  "Retrying RescueJob in 3 seconds." only.
• If event.payload[:wait] is nil, then publish
  "Retrying RescueJob in 0 seconds." instead of "Retrying RescueJob in nil seconds."
• If there is event.payload[:error], then publish
  "Retrying RescueJob in 3 seconds, due to a DefaultsError.".
• Change the type of the message from error to info.

Also, this commit removes part of messages - "The original exception was #{ex.cause.inspect}."
of enqueue_retry.active_job, retry_stopped.active_job, and discard.active_job since I
haven't found it useful. Please let me know whether you agree with that?

r? @kaspth

[rafaelfranca]

Also, this commit removes part of messages - "The original exception was #{ex.cause.inspect}."
of enqueue_retry.active_job, retry_stopped.active_job, and discard.active_job since I
haven't found it useful. Please let me know whether you agree with that?

It is hard to judge that without knowing what that entails. Which information was present in that part of the message that you think it is not useful? Is the exception cause usually blank or is it easy to know what is the cause of the exception? If not how can someone see the cause of the exception easily? Maybe we should keep that part of the message but with a debug level?

[bogdanvlviv]

My judgement was like kind of question since it was based on the test asserting a message "Stopped retrying RetryJob due to a DefaultsError, which reoccurred on 3 attempts. The original exception was #<DefaultsError: DefaultsError>."

rails/activejob/test/cases/logging_test.rb

Lines 188 to 195 in b6b5a7a

	def test_retry_stopped_logging_without_block
	perform_enqueued_jobs do
	begin
	RetryJob.perform_later "DefaultsError", 6
	rescue DefaultsError
	assert_match(/Stopped retrying RetryJob due to a DefaultsError, which reoccurred on \d+ attempts\. The original exception was #<DefaultsError: DefaultsError>\./, @logger.messages)
	end
	end

Seems like enough only to the first part of the message to understand by which kind of exception it was caused - "Stopped retrying RetryJob due to a DefaultsError, which reoccurred on 3 attempts".
The second part is "The original exception was #<DefaultsError: DefaultsError>.".
Unfortunately, I don't have the example that would emphasize that we need the second part of the message. If you have the example, please share.

[bogdanvlviv]

Let me know if there is anything I should change/fix.