Import Action Text #34873
Merged
Import Action Text #34873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just like we use has_many_attachments instead of active_storage_attachements.
This is more like Action View than Active Model.
I don't think we need that since it's set automatically through ActionText::Engine.
…ch-text-area Add test coverage for form with rich_text_area
This constants meant to be private but `private_constant` was missing, this commit makes them fully private by adding `private_constant`.
Privatize constants
I'm not sure if this is going to be used in the future or not, but for the time being we shouldn't maintain parameters that we aren't using. We can always add them later when needed.
This commit renames shadowed variable `attributes`.
Remove unused **options
Rename shadowed variable
Bump CI to latest minor versions of Ruby 2.4 and 2.5
Rails 6 requires Ruby 2.5+ or newer. See #34754.
Remove Ruby 2.4 from the CI matrix
…ill always contain content
use plain test to determine present/blank/empty
When using the `rich_text_area_tag` form helper from within a Rails engine, the direct_upload_url and blob_url_template options would default to non-existent routes. By prefixing these routes with `main_app` we ensure the application root is used rather than the engine.
bogdanvlviv
reviewed
Jan 5, 2019
| require "rubygems" | ||
| require "bundler/setup" | ||
|
|
||
| load Gem.bin_path("webpacker", "webpack") |
There was a problem hiding this comment.
@javan Do we need this and actiontext/bin/webpack-dev-server files because I see they aren't working now on the rails/rails' master branch?
rafaelfranca
reviewed
Jan 7, 2019
| @@ -9,6 +9,7 @@ AllCops: | |||
| - 'actionpack/lib/action_dispatch/journey/parser.rb' | |||
| - 'railties/test/fixtures/tmp/**/*' | |||
| - 'actionmailbox/test/dummy/**/*' | |||
| - 'actiontext/test/dummy/**/*' | |||
There was a problem hiding this comment.
I don't think this put a dummy application inside the framework tests scale in the rails repository. It does make sense for an external plugin but for things that are inside the rails repository we should be following the same railties tests pattern that we have for all the other frameworks. The dummy application get outdated and we will end up testing those engines against a version behind of the one that is being currently being developed.
bogdanvlviv
added a commit
to bogdanvlviv/rails
that referenced
this pull request
Jan 13, 2019
Action Mailbox and Action Text belong to rails/rails since rails#34786 and rails#34873.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.