Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links and code examples in the guides to use HTTPS #35492

Merged
merged 1 commit into from Mar 6, 2019

Conversation

elaine-jackson
Copy link

Summary

Since many of the guide articles were initially written, HTTPS adoption on the internet has skyrocketed. Likewise many hosts that used to not, now do support HTTPS. This patch goes through links in the guides and changes them to use HTTPS.

Additionally if in a code example in a guide article references a website with http that supports https, the link inside the code example was changed to use HTTPS.

Other Information

N/A

@rails-bot rails-bot bot added the docs label Mar 6, 2019
Copy link
Member

@sikachu sikachu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some typos. Would you mind fixing them so I can merge in?

Thank you for the patch!

guides/source/i18n.md Outdated Show resolved Hide resolved
guides/source/routing.md Outdated Show resolved Hide resolved
@sikachu sikachu self-assigned this Mar 6, 2019
@elaine-jackson
Copy link
Author

This commit (c1bc428) should fix the two issues you pointed out. Thanks for reviewing this :)

@vipulnsward
Copy link
Member

Hi @nsuchy please squash your commits

@elaine-jackson
Copy link
Author

elaine-jackson commented Mar 6, 2019 via email

@elaine-jackson
Copy link
Author

@vipulnsward Per your request the commits were squashed on my end.

@rafaelfranca rafaelfranca merged commit 134eaca into rails:master Mar 6, 2019
@elaine-jackson elaine-jackson deleted the patch-1 branch March 6, 2019 22:06
@abhaynikam
Copy link
Contributor

@sikachu @vipulnsward : Sorry for tagging on close PR. I can still see http links in some places like

Is it fine if I update those to https and raise a PR?

@vipulnsward
Copy link
Member

vipulnsward commented Mar 8, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants