New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update links and code examples in the guides to use HTTPS #35492
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some typos. Would you mind fixing them so I can merge in?
Thank you for the patch!
This commit (c1bc428) should fix the two issues you pointed out. Thanks for reviewing this :) |
Hi @nsuchy please squash your commits |
Isn’t that what GitHub’s squash and merge is for? I can squash on my end if necessary although context on why would be nice. I have to attend a meeting (about 90 minutes) then I’ll take care of final touches to this PR :))
Cordially,
Nathaniel Suchy
Mar 6, 2019, 9:54 AM by notifications@github.com:
…
Hi > @nsuchy <https://github.com/nsuchy>> please squash your commits
—
You are receiving this because you were mentioned.
Reply to this email directly, > view it on GitHub <#35492 (comment)>> , or > mute the thread <https://github.com/notifications/unsubscribe-auth/AH2LOX1co9ATjTu5chsJa_yS5DTHQepfks5vT9aOgaJpZM4bf88u>> .
|
@vipulnsward Per your request the commits were squashed on my end. |
@sikachu @vipulnsward : Sorry for tagging on close PR. I can still see
Is it fine if I update those to |
Sure, please do
…On Fri, Mar 8, 2019 at 3:28 PM Abhay Nikam ***@***.***> wrote:
@sikachu <https://github.com/sikachu> @vipulnsward
<https://github.com/vipulnsward> : Sorry for tagging on close PR. I can
still see http links in some places like
-
https://github.com/rails/rails/blob/master/.github/pull_request_template.md
-
https://github.com/rails/rails/blob/master/actioncable/actioncable.gemspec#L18
Is it fine if I update those to https and raise a PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#35492 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAipSkq5pYYNmDn0JhBywnfZRFBFjoe4ks5vUjRBgaJpZM4bf88u>
.
|
Summary
Since many of the guide articles were initially written, HTTPS adoption on the internet has skyrocketed. Likewise many hosts that used to not, now do support HTTPS. This patch goes through links in the guides and changes them to use HTTPS.
Additionally if in a code example in a guide article references a website with http that supports https, the link inside the code example was changed to use HTTPS.
Other Information
N/A