Updated links from http to https in guides, docs, etc #35529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhaynikam
commented
Mar 8, 2019
| @@ -15,7 +15,7 @@ Gem::Specification.new do |s| | |||
|
|
|||
| s.author = "David Heinemeier Hansson" | |||
| s.email = "david@loudthinking.com" | |||
| s.homepage = "http://rubyonrails.org" | |||
| s.homepage = "https://rubyonrails.org" | |||
There was a problem hiding this comment.
I have added ci skip to this, but will change in gemspec anyways affect anything?
There was a problem hiding this comment.
Should not add [ci skip], gemspec is definitely not doc, but Ruby code.
There was a problem hiding this comment.
@kamipo : Removed [ci skip] and fixed other comments too.
kamipo
reviewed
Mar 9, 2019
abhaynikam
force-pushed
the
35492-follow-up-to-updates-links-to-https
branch
from
0876e5a
to
6268fd0
Compare
kamipo
reviewed
Mar 9, 2019
actioncable/README.md
Outdated
| @@ -13,7 +13,7 @@ You can read more about Action Cable in the [Action Cable Overview](https://edge | |||
|
|
|||
| API documentation is at: | |||
|
|
|||
| * http://api.rubyonrails.org | |||
| * https://api.rubyonrails.org/ | |||
There was a problem hiding this comment.
My Bad. Fixed it now.
abhaynikam
force-pushed
the
35492-follow-up-to-updates-links-to-https
branch
from
6268fd0
to
476abd4
Compare
|
Thanks, @kamipo . I missed a few gemspec files to update the links to https. Is it okay if I reopen a new PR for it? |
|
Confirmed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted few links which can be converted to HTTPS after PR #35492
ref: #35492 (comment)
@r? @vipulnsward