Fix test failing on ruby master #41115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghiculescu
force-pushed
the
failing-test-on-ruby-master
branch
from
467bf36
to
c04f416
Compare
ghiculescu
force-pushed
the
failing-test-on-ruby-master
branch
from
c04f416
to
1e86a04
Compare
ghiculescu
force-pushed
the
failing-test-on-ruby-master
branch
from
1e86a04
to
f9b4de0
Compare
gmcgibbon
reviewed
Jan 14, 2021
gmcgibbon
approved these changes
Jan 14, 2021
kamipo
pushed a commit
that referenced
this pull request
Mar 15, 2021
Fix test failing on ruby master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruby/bigdecimal#180 is causing a test to fail when running activerecord against ruby master (eg. here). I've reported that to the author here: ruby/bigdecimal#70 (comment) - but I'm not sure if it's considered correct behavior or not.
In the meantime, I replaced it with tests where there should be no doubt about which direction to round in.
cc @gmcgibbon since you added the test originally.