Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failing on ruby master #41115

Merged
merged 1 commit into from
Jan 14, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -81,17 +81,45 @@ def self.name
assert_predicate(subject, :valid?)
end

def test_virtual_attribute_with_precision
def test_virtual_attribute_with_precision_round_down
model_class.attribute(:virtual_decimal_number, :decimal, precision: 5)
model_class.validates_numericality_of(
:virtual_decimal_number, equal_to: 123.45
)

subject = model_class.new(virtual_decimal_number: 123.455)
subject = model_class.new(virtual_decimal_number: 123.454)

assert_predicate subject, :valid?
end

def test_virtual_attribute_with_precision_round_half_even
model_class.attribute(:virtual_decimal_number, :decimal, precision: 5)
model_class.validates_numericality_of(
:virtual_decimal_number, equal_to: 123.45
)

subject = model_class.new(virtual_decimal_number: 123.455)

if RUBY_VERSION > "3.0.0"
gmcgibbon marked this conversation as resolved.
Show resolved Hide resolved
# BigDecimal's to_d behavior changed in BigDecimal 3.0.1, see https://github.com/ruby/bigdecimal/issues/70
# TOOD: replace this with a check against BigDecimal::VERSION
assert_not_predicate subject, :valid?
else
assert_predicate subject, :valid?
end
end

def test_virtual_attribute_with_precision_round_up
model_class.attribute(:virtual_decimal_number, :decimal, precision: 5)
model_class.validates_numericality_of(
:virtual_decimal_number, equal_to: 123.45
)

subject = model_class.new(virtual_decimal_number: 123.456)

assert_not_predicate subject, :valid?
end

def test_virtual_attribute_with_scale
model_class.attribute(:virtual_decimal_number, :decimal, scale: 2)
model_class.validates_numericality_of(
Expand Down