Regression when redefining a store attribute with a new type

[georgeclaghorn]

We have a model that defines a store attribute, then redefines it with a wrapper type for encryption, like so:

class Cache < ApplicationRecord
  store :data
  encrypts :data
end

The encrypts macro boils down to:

def encrypts(name)
  attribute name, :encrypted, subtype: type_for_attribute(name)
end

After 4cc9c0f, values stored in the data attribute no longer make it to the DB:

> Cache.create! data: { trial: true }
Cache Create (0.1ms)  INSERT INTO "caches" DEFAULT VALUES

I’ve shared a minimal reproduction script as a gist.

Apologies in advance if we’re just Doing It Wrong and need to change the way we decorate attributes. I’m not familiar enough with Active Record’s attributes system to know that off the top of my head or to understand what Jonathan’s commit changed.

/cc @jonathanhefner @kamipo