Don't hide _method param in logs; Issue #426 #427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiding the _method param leaves no indication in the Rails log that a request would be interpreted by the Rails app according to the method override.
|
The Rails log already shows you what kind of a request it is. We don't need to repeat this again in the log by exposing _method. Teaching people that it's there is a 1-time piece of information that's not worth cluttering the log with for all time thereafter. |
|
So you're saying issue #426 is not reproducible? I don't see any indication in the Rails log that tells me that a PUT request is a PUT request. |
|
Yeah, I see the problem. We should fix that at its root rather than get _method in there. |
|
Ah, didn't realize it was a regression. |
matthewd
pushed a commit
that referenced
this pull request
Apr 24, 2018
- Disable jruby-head since bundle fetching is failing on travis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiding the _method param leaves no indication in the Rails log that a request
would be interpreted by the Rails app according to the method override.