Refactor form_for tests to stop re-assigning @output_buffer #45745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's really not what it's meant for. `@renderer` is a better use for this as it's the variable used by the DOM testing helpers. Ref: rails#45731
casperisfine
pushed a commit
to Shopify/rails
that referenced
this pull request
Aug 3, 2022
Followup on rails#45745 `@rendered` is a much better variable for this kind of intermediate result as that's what is used by DOM assertions.
byroot
added a commit
that referenced
this pull request
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #45731
It's really not what it's meant for.
@rendereris a better use for this as it's the variable used by the DOM testing helpers.Shipping this independently, as I don't like changing tests as part of feature refactors if I can avoid it.
These tests are in the way of various followup after #45731.
FYI: @jhawthorn, @BlakeWilliams (I'll merge on green)