Support stale state detections in CPK through associations #48606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stale states need to be tracked as arrays to properly check through associations with composite primary keys.
gmcgibbon
force-pushed
the
stale_state_cpk
branch
from
8e6a13b
to
755c13f
Compare
4 tasks
JoeDupuis
added a commit
to JoeDupuis/rails
that referenced
this pull request
Aug 21, 2023
PR rails#48606 introduced a regression preventing the creation of a chain of models using a has_one through association when strict_loading is activated. The association relies on the initial stale_state being `nil` to skip loading the target. https://github.com/gmcgibbon/rails/blob/755c13f167af4fddc6960ed3768ed7e178a2395a/activerecord/lib/active_record/associations/association.rb#L175 PR rails#48606 initializes the stale_state to `[nil]` https://github.com/rails/rails/pull/48606/files#diff-39c3da3c5f3fbff01b0a32d3b7ec613fda6bc6225fdbe2629134d91babe37786R84-R86 This change converts the `[nil]` state back to `nil`.
paulreece
pushed a commit
to paulreece/rails-paulreece
that referenced
this pull request
Aug 26, 2023
PR rails#48606 introduced a regression preventing the creation of a chain of models using a has_one through association when strict_loading is activated. The association relies on the initial stale_state being `nil` to skip loading the target. https://github.com/gmcgibbon/rails/blob/755c13f167af4fddc6960ed3768ed7e178a2395a/activerecord/lib/active_record/associations/association.rb#L175 PR rails#48606 initializes the stale_state to `[nil]` https://github.com/rails/rails/pull/48606/files#diff-39c3da3c5f3fbff01b0a32d3b7ec613fda6bc6225fdbe2629134d91babe37786R84-R86 This change converts the `[nil]` state back to `nil`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because stale stack checking for
has_many/has_onethrough relations doesn't currently work for composite primary key relations.Detail
This Pull Request changes stale states so that they are tracked as an array of columns to properly check through associations with composite primary keys.
Additional information
My tests might be too close to the implementation. Let me know if I should improve that.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]