Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,9 @@ def construct_join_attributes(*records)
# to try to properly support stale-checking for nested associations.
def stale_state
if through_reflection.belongs_to?
owner[through_reflection.foreign_key] && owner[through_reflection.foreign_key].to_s
Array(through_reflection.foreign_key).map do |foreign_key_column|
owner[foreign_key_column] && owner[foreign_key_column].to_s
end
end
end

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1639,6 +1639,17 @@ def test_loading_cpk_association_with_unpersisted_owner
assert_equal([order_agreement], book.order_agreements.to_a)
end

def test_cpk_stale_target
order = Cpk::Order.create!(shop_id: 1)
book = Cpk::BookWithOrderAgreements.create!(id: [1, 2], order: order)
Cpk::OrderAgreement.create!(order: order)

book.order_agreements.load
book.order = Cpk::Order.new

assert_predicate(book.association(:order_agreements), :stale_target?)
end

private
def make_model(name)
Class.new(ActiveRecord::Base) { define_singleton_method(:name) { name } }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -454,4 +454,15 @@ def test_loading_cpk_association_with_unpersisted_owner

assert_equal(order_agreement, book.order_agreement)
end

def test_cpk_stale_target
order = Cpk::Order.create!(shop_id: 1)
book = Cpk::BookWithOrderAgreements.create!(id: [1, 2], order: order)
Cpk::OrderAgreement.create!(order: order)

book.order_agreement
book.order = Cpk::Order.new

assert_predicate(book.association(:order_agreement), :stale_target?)
end
end