Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci-skip][Docs]Add raise_on_missing_callback_actions to configuring guide #49565

Merged
merged 2 commits into from Oct 10, 2023

Conversation

hachi8833
Copy link
Contributor

Motivation / Background

This Pull Request has been created because I found config.action_controller.raise_on_missing_callback_actions that has been added by #43487 is missing in current configuring guides.

Detail

This Pull Request adds the entry for config.action_controller.raise_on_missing_callback_actions.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]

@rails-bot rails-bot bot added the docs label Oct 10, 2023
Raises an `AbstractController::ActionNotFound` when the action specified in callback's `:only` or `:except` options is missing in the controller.

The default value is `false`.
In newly generated 7.1+ app, the default values in config/environments.development.rb and test.rb will be configured as `true`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use the same table for displaying these defaults that's used in other configs (eg raise_on_open_redirects)? That way all the examples are consistent 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghiculescu Thank you for reviewing! updated.

@MatheusRich
Copy link
Contributor

LGTM

@vipulnsward vipulnsward merged commit 77a5605 into rails:main Oct 10, 2023
3 checks passed
@hachi8833 hachi8833 deleted the add_missing_doc_43487 branch October 10, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants