Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci-skip][Docs]Add raise_on_missing_callback_actions to configuring guide #49565

Merged
merged 2 commits into from Oct 10, 2023
Merged

[ci-skip][Docs]Add raise_on_missing_callback_actions to configuring guide #49565

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8763271
Add raise_on_missing_callback_actions to configuring guide
hachi8833 Oct 6, 2023
4d4f80d
Update raise_on_open_redirects config with table style
hachi8833 Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions guides/source/configuring.md
View file
Open in desktop
Expand Up @@ -1743,6 +1743,13 @@ Rendered messages/_message.html.erb in 1.2 ms [cache hit]
Rendered recordings/threads/_thread.html.erb in 1.5 ms [cache miss]
```

#### `config.action_controller.raise_on_missing_callback_actions`

Raises an `AbstractController::ActionNotFound` when the action specified in callback's `:only` or `:except` options is missing in the controller.

The default value is `false`.
In newly generated 7.1+ app, the default values in config/environments.development.rb and test.rb will be configured as `true`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use the same table for displaying these defaults that's used in other configs (eg raise_on_open_redirects)? That way all the examples are consistent 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghiculescu Thank you for reviewing! updated.


#### `config.action_controller.raise_on_open_redirects`

Raises an `ActionController::Redirecting::UnsafeRedirectError` when an unpermitted open redirect occurs.
Expand Down