Add rubocop-rails-omakase to new Rails applications #50486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This setups a basic rubocop config for new rails apps using the `rubocop-rails-omakase` gem: https://github.com/rails/rubocop-rails-omakase It can be skipped with the `--skip-rubocop` flag.
zzak
commented
Dec 29, 2023
Based on rubygems/rubygems#6915 This occurs especially when generating a new rails app within a rails checkout: https://github.com/rails/rails/actions/runs/7360317953/job/20036287021#step:4:171
vipulnsward
reviewed
Dec 29, 2023
railties/lib/rails/generators/rails/app/templates/.rubocop.yml.tt
Outdated
Show resolved
Hide resolved
This way we get the permissions and shebang for free.
Since we were calling the rubocop command before, and not the patched binstub.
dhh
reviewed
Dec 30, 2023
dhh
reviewed
Dec 30, 2023
railties/lib/rails/generators/rails/app/templates/.rubocop.yml.tt
Outdated
Show resolved
Hide resolved
dhh
reviewed
Dec 30, 2023
|
Flaky CI. Random tests dying with: 
|
|
Thanks for the review! I was trying to debug the CI failures here, but fell asleep 😴 Looking into them now: |
This was referenced Dec 31, 2023
koic
reviewed
Jan 1, 2024
| def test_rubocop_is_skipped_if_required | ||
| run_generator [destination_root, "--skip-rubocop"] | ||
|
|
||
| assert_no_gem "rubocop" |
There was a problem hiding this comment.
Could it be rubocop-rails-omakase, instead of rubocop?
-assert_no_gem "rubocop"
+assert_no_gem "rubocop-rails-omakase"
There was a problem hiding this comment.
@koic You're right. Raising a PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50456
This setups a basic rubocop config for new rails apps using the
rubocop-rails-omakasegem: https://github.com/rails/rubocop-rails-omakaseIt can be skipped with the
--skip-rubocopflag.