Lock sprockets to 2.2.x #8161
Merged
Lock sprockets to 2.2.x #8161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfranca
added a commit
that referenced
this pull request
Nov 9, 2012
Lock sprockets to 2.2.x REASON: We had some pending fixes in sprockets and sass-rails to make possible to use sprockets version > 2.2. We will do a more conservative sprockets upgrade for this release. In a next release we can relax the dependency again. See #8099 for more information.
rafaelfranca
added a commit
that referenced
this pull request
Nov 9, 2012
Lock sprockets to 2.2.x REASON: We had some pending fixes in sprockets and sass-rails to make possible to use sprockets version > 2.2. We will do a more conservative sprockets upgrade for this release. In a next release we can relax the dependency again. See #8099 for more information.
|
But this forces 3.2.8 apps on newer sprockets to downgrade when they upgrade to 3.2.9. |
|
3.2.8 depends on |
|
confirm, 3.2.8 is depending in 2.1.3 |
|
Great! I thought 83e0c95 was applied before release. |
|
Why is Sprockets still locked now that #8099 is fixed? |
|
Ah, nevermind. I see that the Sprockets-dependency has been pulled into sprockets-rails in Rails 4. |
|
What about Rails 3.2.x apps ? As #8099 is solved, shouldn't they also use the latest sprockets version 2.9.x ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails is failing with sprockets >= 2.3, see #8099 for reference and discussion.
I think we should address the issue anyway and relax the dependency again later but right now this is being a blocker for 3.2.9 release since last week.
We isolated the problem to sass-rails but we don't have much idea right now about how to fix it