Introduce test on Error#full_message for attribute with underscores; Fix...

[vipulnsward]

1. Introduce test on Error#full_message for attribute with underscores
2. Fix typo in test names

[senny]

Why is the new test relevant? Was there a change in behavior regarding attributes with underscores? Is it to prevent regressions?

Also it would be great if you could shorten your commit message. Github does not like long commit messages. You can always do a short description on the first line, then a blank line and then add a detailed description.

[vipulnsward]

About the comments: Will keep in mind the next time

While scanning through Error model, I found the tr(".","_") and humanize on the result in full_messages.

The behaviour for having _ in the name is different than having a .

Ex:
Model.nestedattr => Model nestedattr
but model_test maps to model_test itself

Test for previous behaviour is present the latter isn't, so added the test.

[senny]

I see.

Regarding the commit message, you can easily update it by using git commit --amend or git rebase -i and then issue a force push on your branch fix_test_AR_v2. The PR on Github will reflect the changes automatically.

[vipulnsward]

@senny updating in some time

[vipulnsward]

Fixed message

[vipulnsward]

//cc @carlosantoniodasilva @rafaelfranca