Subdomain route constraints fix #10185

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

derek-watson commented Apr 12, 2013

Fixes #10180

  • Passing subdomain: '' to url_for removes the subdomain (instead of adding a leading .)
  • Adding a boolean route constraint checks for presence/absence of request property
@derek-watson derek-watson Passing subdomain: '' to url_for removes the subdomain (instead of ad…
…ding a leading .)

Adding a boolean route constraint checks for presence/absence of request property
dd42962

Maybe unless options[:subdomain].presence is what we need here? It will be more concise and useful.

Owner

derek-watson replied Apr 16, 2013

That would incorrectly strip the subdomain from the URL when no subdomain option was passed. The current and desirable behaviour is to keep you on your current subdomain.

@pixeltrix pixeltrix added a commit that referenced this pull request Apr 18, 2013

@pixeltrix pixeltrix Add url generation tests for #10185 c102440
Owner

pixeltrix commented Apr 18, 2013

Merged in 6183e1a - thanks @derek-watson

pixeltrix closed this Apr 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment