Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose better documentation for ActiveSupports next_week functionaility #10351

Merged
merged 2 commits into from
Apr 26, 2013

Conversation

JonRowe
Copy link
Contributor

@JonRowe JonRowe commented Apr 25, 2013

Update documentation for next_week(:day) to better reflect implementation.

Asking a Date(Time) for next_week is the equivalent of saying 'Give me day X in next week' but the original documentation makes it seem like the parameter is the start of next week.

This PR updates the documentation to reflect the reality, e.g. asking for next_week(:wednesday) is the equivalent of the english statement 'next wednesday' or 'the wednesday in next week'.

This will clear up misunderstandings like #9568

@fxn
Copy link
Member

fxn commented Apr 26, 2013

Nice, the guide already explains it that way. Mind putting DateTime in fixed-width font please?

@JonRowe
Copy link
Contributor Author

JonRowe commented Apr 26, 2013

Sure thing @fxn

@fxn
Copy link
Member

fxn commented Apr 26, 2013

Awesome appreciate it.

fxn added a commit that referenced this pull request Apr 26, 2013
…cument_intent

Propose better documentation for ActiveSupports `next_week` functionaility
@fxn fxn merged commit 11e23b9 into rails:master Apr 26, 2013
@JonRowe
Copy link
Contributor Author

JonRowe commented Apr 26, 2013

Thanks :)

@JonRowe JonRowe deleted the update_as_date_next_week_to_document_intent branch September 5, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants