Add PK constraint on bigserial ID columns on postgres adapter #10455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rails#10410 it was noted that you can no longer create PK's with the type of bigserial in PostgreSQL in 4.0.0.rc1. This is mostly because the newer adapter is checking for column type with the id column instead of just letting it pass through like it did before. Side effects: You may just create a PK column of a type that you really don't want to be your PK. As far as I can tell this was allowed in 3.2.X and perhaps an exception should be raised if you try and do something extremely dumb.
|
@tenderlove this might be ready for your review now. |
tenderlove
added a commit
that referenced
this pull request
May 7, 2013
…ntifying_pk Add PK constraint on bigserial ID columns on postgres adapter
tenderlove
added a commit
that referenced
this pull request
May 7, 2013
…ntifying_pk Add PK constraint on bigserial ID columns on postgres adapter
| @@ -359,8 +359,12 @@ class TableDefinition < ActiveRecord::ConnectionAdapters::TableDefinition | |||
| # a record (as primary keys cannot be +nil+). This might be done via the | |||
| # +SecureRandom.uuid+ method and a +before_save+ callback, for instance. | |||
| def primary_key(name, type = :primary_key, options = {}) | |||
| return super unless type == :uuid | |||
| options[:default] = options.fetch(:default, 'uuid_generate_v4()') | |||
| return super unless type = :primary_key | |||
There was a problem hiding this comment.
This line seems wrong. Can you run the pg tests and resend a pull request?
There was a problem hiding this comment.
That line is indeed very wrong. Will correct it in a sec.
|
Sorry, I should have reviewed more closely, but this PR seems wrong. I'm reverting the merge commit. Can you check the pg tests and resubmit? Specifically we're getting a failure on: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #10410 it was noted that you can no longer create PK's with the
type of bigserial in PostgreSQL in 4.0.0.rc1. This is mostly
because the newer adapter is checking for column type with the
id column instead of just letting it pass through like it did
before.
Side effects:
You may just create a PK column of a type that you really don't
want to be your PK. As far as I can tell this was allowed in 3.2.X
and perhaps an exception should be raised if you try and do
something extremely dumb.