Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup some useless code #10753

Closed
wants to merge 1 commit into from
Closed

Conversation

bogdan
Copy link
Contributor

@bogdan bogdan commented May 25, 2013

Nested parameters are processed in the same way as not nested parameters - no reason to have custom code for them.

@josevalim
Copy link
Contributor

This patch actually provides a very subtle change in behavior. Before this patch, Active Record guaranteed that the nested hash would be assigned after regular parameters and this patch removes this guarantee. Now if the previous behavior was intentional or not is a question that should be asked.

@bogdan
Copy link
Contributor Author

bogdan commented May 25, 2013

Hm, that's interesting. If it is intentional there should be a test for it.

But first of all can you explain how this behavior appeared?

@josevalim
Copy link
Contributor

I don't know how this behaviour appeared as it is impossible to know everything that happens to Rails. :)

I blamed the source code and went through history, this commit seems to have done it: 774ff18

@homakov
Copy link
Contributor

homakov commented May 25, 2013

@bogdan Our pull requests are just same.

@bogdan
Copy link
Contributor Author

bogdan commented May 25, 2013

@homakov hehe. Closing this one than.

@bogdan bogdan closed this May 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants