New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated Time
methods
#11265
Conversation
@@ -1,3 +1,8 @@ | |||
* Remove deprecated `Time#time_with_datetime_fallback`, `Time#utc_time` | |||
and `Time#local_time` in favour of `Time#utc` and `Time#local` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indent looks weird.
@senny updated |
@@ -1,3 +1,8 @@ | |||
* Remove deprecated `Time#time_with_datetime_fallback`, `Time#utc_time` | |||
and `Time#local_time` in favour of `Time#utc` and `Time#local` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"favour" => "favor"
@senny updated. |
@@ -1,3 +1,8 @@ | |||
* Remove deprecated `Time#time_with_datetime_fallback`, `Time#utc_time` | |||
and `Time#local_time` in favor of `Time#utc` and `Time#local` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing final .
:)
👍 |
and `Time#local_time` in favour of `Time#utc` and `Time#local`
@carlosantoniodasilva updated 😄 |
@vipulnsward thanks. @senny all yours :) |
@thanks guys! 💛 |
Remove deprecated
Time#time_with_datetime_fallback
,Time#utc_time
andTime#local_time
in favour ofTime#utc
andTime#local