Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Time methods #11265

Merged
merged 1 commit into from Jul 3, 2013

Conversation

vipulnsward
Copy link
Member

Remove deprecated Time#time_with_datetime_fallback, Time#utc_time and Time#local_time in favour of Time#utc and Time#local

@@ -1,3 +1,8 @@
* Remove deprecated `Time#time_with_datetime_fallback`, `Time#utc_time`
and `Time#local_time` in favour of `Time#utc` and `Time#local`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent looks weird.

@vipulnsward
Copy link
Member Author

@senny updated

@@ -1,3 +1,8 @@
* Remove deprecated `Time#time_with_datetime_fallback`, `Time#utc_time`
and `Time#local_time` in favour of `Time#utc` and `Time#local`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"favour" => "favor"

@vipulnsward
Copy link
Member Author

@senny updated.

@@ -1,3 +1,8 @@
* Remove deprecated `Time#time_with_datetime_fallback`, `Time#utc_time`
and `Time#local_time` in favor of `Time#utc` and `Time#local`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing final . :)

@carlosantoniodasilva
Copy link
Member

👍

    and `Time#local_time` in favour of `Time#utc` and `Time#local`
@vipulnsward
Copy link
Member Author

@carlosantoniodasilva updated 😄

@carlosantoniodasilva
Copy link
Member

@vipulnsward thanks.

@senny all yours :)

senny added a commit that referenced this pull request Jul 3, 2013
@senny senny merged commit f34b318 into rails:master Jul 3, 2013
@senny
Copy link
Member

senny commented Jul 3, 2013

@thanks guys! 💛

@vipulnsward vipulnsward deleted the deprecated_time_methods branch February 22, 2016 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants