Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup on getting_started tutorial #11324

Merged
merged 1 commit into from Jul 6, 2013
Merged

Conversation

blahedo
Copy link
Contributor

@blahedo blahedo commented Jul 6, 2013

A few places in the tutorial were confusing to beginners for various reasons (or incorrect), so I cleaned them up.

@arunagw
Copy link
Member

arunagw commented Jul 6, 2013

Will be great if you can add [ci skip] as well in commit message for guides.

@steveklabnik
Copy link
Member

I vaguely remember that @dhh had an option on <br> vs <br />, which is why the scaffolds output <br>, but I could be totally wrong.

The other changes look good, this will need squashed, and don't forget to [ci skip] when you do.

@dhh
Copy link
Member

dhh commented Jul 6, 2013

Yes,
is for XHTML. That's not what we intend to output. We intend to output HTML5.

On Jul 6, 2013, at 15:28, Steve Klabnik notifications@github.com wrote:

I vaguely remember that @dhh had an option on
vs
, which is why the scaffolds output
, but I could be totally wrong.

The other changes look good, this will need squashed, and don't forget to [ci skip] when you do.


Reply to this email directly or view it on GitHub.

@blahedo
Copy link
Contributor Author

blahedo commented Jul 6, 2013

Ok, I'll fix the <br> the other way (and in the other doc files too). Thanks for the heads-up on ci skip; I'm new to github and hadn't heard of Travis-CI before. :)

@rafaelfranca
Copy link
Member

Could you squash your commits and force push for your branch?

Replaced <br /> with <br> for consistency; Added note about
singular/plural distinction (which was previously confusing to a Rails
noob); Rephrased explanation of how form is routed to controller, again
to reduce confusion; and added explanation to replace incorrect link.
[ci skip]
@blahedo
Copy link
Contributor Author

blahedo commented Jul 6, 2013

Thanks for your patience. I think that does what you need.

rafaelfranca added a commit that referenced this pull request Jul 6, 2013
Cleanup on getting_started tutorial
@rafaelfranca rafaelfranca merged commit 2ae5452 into rails:master Jul 6, 2013
@rafaelfranca
Copy link
Member

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants