Syntax cleanup: for in => each on ActiveRecord #1161

Merged
merged 2 commits into from May 20, 2011

Conversation

Projects
None yet
3 participants
Owner

guilleiguaran commented May 20, 2011

No description provided.

Owner

fxn commented May 20, 2011

I personally like the for loop, but #each is considered to be much more idiomatic for sure, and it is what the code base uses, so good :).

fxn added a commit that referenced this pull request May 20, 2011

Merge pull request #1161 from guilleiguaran/each_syntax_in_activerecord
Syntax cleanup:  for in => each on ActiveRecord

@fxn fxn merged commit 5b8bc46 into rails:master May 20, 2011

Contributor

asanghi commented May 20, 2011

Would be nice however, if it was done in one whole swoop though, so the core team doesnt have the hassle of doing smaller bit by bit commits?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment