Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ActiveSupport::Testing::Isolation on jruby #11712

Merged

Commits on Aug 2, 2013

  1. Fix ActiveSupport::Testing::Isolation on jruby

    Hopefully the first of many related to rails#11700.
    
    With these changes the railties tests wont 100% pass but at least they
    will run and show the errors.
    
    The first problem was the @method_name variable was never set.
    This was causing ENV["ISOLATION_TEST"] to always be nil which
    would cause the test output to never be written to the tempfile.
    
    The second problem was that an invalid -t option was being passed
    to minitest and minitest was erroring out.
    
    The third problem was the run method needs to always return an
    instance of the test class it is trying to isolate. We were returning
    a ProxyTestResult instead.
    atambo committed Aug 2, 2013
    Copy the full SHA
    560541f View commit details
    Browse the repository at this point in the history