Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the Rails maintenance policy to the Guides #12171

Merged
merged 1 commit into from Oct 2, 2013

Conversation

matiaskorhonen
Copy link
Contributor

I propose that we add the Rails maintenance policy to the Ruby on Rails Guides.

At the moment if you want to check the maintenance policy you have to find the blog post about it way from back in February and it doesn't seem to have been updated after Rails 4 was released.

Ideally Rails Guides should be the canonical source for the maintenance policy (and I think there would be a better chance of it staying up-to-date from release to release)…

I've done my best to update the maintenance policy to the current state from the blog post from February and I'm fairly certain that it reflects reality, but someone more knowledgeable should check it to be sure.

@vesan
Copy link
Contributor

vesan commented Sep 9, 2013

ping @steveklabnik

@pftg
Copy link
Contributor

pftg commented Sep 9, 2013

Please add [ci skip] to commit message.

Maintenance policy for Ruby on Rails
====================================

Since the most recent patch releases there has been some confusion about what versions of Ruby on Rails are currently supported, and when people can expect new versions. Our maintenance policy is as follows.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May you use 80 chars width for lines.

@matiaskorhonen
Copy link
Contributor Author

Updated the PR with wrapped lines and [ci skip]

@pftg
Copy link
Contributor

pftg commented Sep 9, 2013

👍


You should also be aware that Ruby 1.8 reached End of Life in June 2013, no
further Ruby security releases will be provided. If your application is only
compatible Ruby 1.8 you should upgrade accordingly.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't needed because we don't support 1.8 at all any more.

@steveklabnik
Copy link
Member

I wish I'd thought of this. @fxn?

@matiaskorhonen
Copy link
Contributor Author

I removed the note about Ruby 1.8, would you like me to squash the commits?

@steveklabnik
Copy link
Member

Yes, please.

@matiaskorhonen
Copy link
Contributor Author

OK, done.

@rafaelfranca
Copy link
Member

I don't think this belongs to rails guides. This is an intitutional
information and I think it belongs to the website.

On Monday, September 9, 2013, Steve Klabnik wrote:

I wish I'd thought of this. @fxn https://github.com/fxn?


Reply to this email directly or view it on GitHubhttps://github.com//pull/12171#issuecomment-24085745
.

Rafael Mendonça França
http://twitter.com/rafaelfranca
https://github.com/rafaelfranca

@matiaskorhonen
Copy link
Contributor Author

I think it's fairly logical to find it in the guides, especially as that's where you find the release notes for major versions…

@matiaskorhonen
Copy link
Contributor Author

Also, perhaps it's an inditement of the current state of the Rails website, but I (at least) almost never go looking for up-to-date information about Rails on the Rails website (aside from the blog).

@robin850
Copy link
Member

I think that we should better add this to the contribution guideline just with a link pointing to the article.

@matiaskorhonen
Copy link
Contributor Author

The maintenance policy isn't important just to contributors, it affects every person developing anything on top of Rails… Plus it has extremely important security implications for everyone who works with Rails.

@robin850
Copy link
Member

@matiaskorhonen : Uh, good point!

@arthurnn
Copy link
Member

arthurnn commented Oct 2, 2013

Should 'Bug fixes' go to 3.2.x too?

@rafaelfranca
Copy link
Member

@arthurnn see http://weblog.rubyonrails.org/2013/7/23/Rails-3-2-14-has-been-released/

I also want to announce that the next 3.2.x release, 3.2.15, will be the last bug fix release of this family. After it we will only release security fixes. So, if you have issues on 3.2.x that you think should be included on 3.2.15, let us know thought the GitHub issues page and in 3 months we'll evaluate if it is time to release.

@fxn
Copy link
Member

fxn commented Oct 2, 2013

Hey I am 👍 on adding this to the guides. Will check the details of the PR later today.

@fxn
Copy link
Member

fxn commented Oct 2, 2013

Yeah, I have been browsing the website and don't quite see this page there. The home is kind of in a higher/broader level in my view.

The other extreme would be a file in the root directory of the project or something, but as has been already said, the maintenance policy is something that interests to different kind of people and for some this wouldn't be a good way of communicating it.

And definitely as a blog post cannot fly, we need it documented in the project.

A guide seems like a good place to me, since they already deviate a little bit from the pure documentation of topics with the release notes.

So in principle my vote is positive. Would like to suggest two things:

  • These are not release notes, let's create a new section "Maintenance Policy" with one single guide of the same title.
  • This also needs a CHANGELOG entry.

@rafaelfranca
Copy link
Member

Make sense. Thank you for taking care of this one

@matiaskorhonen
Copy link
Contributor Author

I added a separate section for the maintenance policy, added an entry to the CHANGELOG, and squashed everything into a single commit.

@fxn
Copy link
Member

fxn commented Oct 2, 2013

Awesome, thanks for working on this.

fxn added a commit that referenced this pull request Oct 2, 2013
…-to-guides

Adds the Rails maintenance policy to the Guides
@fxn fxn merged commit 640c15b into rails:master Oct 2, 2013
@matiaskorhonen matiaskorhonen deleted the adds-maintenance-policy-to-guides branch September 13, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants