Fix some edge cases for select with selected option #12287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems good. Could you add a CHANGELOG entry? |
|
done. |
|
@bogdan I think you forgot to push the CHANGELOG 😄 |
|
ok, waiting for #11055 to be merged first to prevent yet another changelog rebase (they gonna kill me one day) |
|
#11055 merged |
rafaelfranca
added a commit
that referenced
this pull request
Sep 23, 2013
Fix some edge cases for select with selected option
rafaelfranca
added a commit
that referenced
this pull request
Sep 23, 2013
Fix some edge cases for select with selected option Conflicts: actionview/CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Select should use selected option as value when specified in all layers
This is not always true right now. That is why prompt option could not
work correctly. See tests for examples.