Skip to content

cast json values on write to be consistent with reading from the db.#12643

Merged
senny merged 1 commit intorails:masterfrom
severin:pg_cast_json_on_write
Oct 25, 2013
Merged

cast json values on write to be consistent with reading from the db.#12643
senny merged 1 commit intorails:masterfrom
severin:pg_cast_json_on_write

Conversation

@severin
Copy link
Copy Markdown
Contributor

@severin severin commented Oct 25, 2013

This is analog to what commit 5ac2341 did with hstore fields...

/cc @senny

Comment thread activerecord/CHANGELOG.md Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hstore should be json I guess.

@senny
Copy link
Copy Markdown
Member

senny commented Oct 25, 2013

Does #12490 also completely apply for this change?

@severin
Copy link
Copy Markdown
Contributor Author

severin commented Oct 25, 2013

In senny@557b8b6 you added a test that verifies that store_accessor works with json columns and the test still passes

@senny
Copy link
Copy Markdown
Member

senny commented Oct 25, 2013

looks great! Thank you for your contribution 💛

senny added a commit that referenced this pull request Oct 25, 2013
cast json values on write to be consistent with reading from the db.
@senny senny merged commit dc8fac1 into rails:master Oct 25, 2013
@severin
Copy link
Copy Markdown
Contributor Author

severin commented Oct 25, 2013

You're very welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants