Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cast json values on write to be consistent with reading from the db. #12643

Merged
merged 1 commit into from Oct 25, 2013

Conversation

severin
Copy link
Contributor

@severin severin commented Oct 25, 2013

This is analog to what commit 5ac2341 did with hstore fields...

/cc @senny

@@ -1,3 +1,18 @@
* Type cast hstore values on write, so that the value is consistent
Copy link
Member

@senny senny Oct 25, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hstore should be json I guess.

@senny
Copy link
Member

senny commented Oct 25, 2013

Does #12490 also completely apply for this change?

@severin
Copy link
Contributor Author

severin commented Oct 25, 2013

In senny@557b8b6 you added a test that verifies that store_accessor works with json columns and the test still passes

@senny
Copy link
Member

senny commented Oct 25, 2013

looks great! Thank you for your contribution 💛

senny added a commit that referenced this pull request Oct 25, 2013
cast json values on write to be consistent with reading from the db.
@senny senny merged commit dc8fac1 into rails:master Oct 25, 2013
@severin
Copy link
Contributor Author

severin commented Oct 25, 2013

You're very welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants