Merge pull request #12643 from severin/pg_cast_json_on_write

cast json values on write to be consistent with reading from the db.

activerecord/CHANGELOG.md

@@ -1,3 +1,18 @@
+*   Type cast json values on write, so that the value is consistent
+    with reading from the database.
+
+    Example:
+
+        x = JsonDataType.new tags: {"string" => "foo", :symbol => :bar}
+
+        # Before:
+        x.tags # => {"string" => "foo", :symbol => :bar}
+
+        # After:
+        x.tags # => {"string" => "foo", "symbol" => "bar"}
+
+    *Severin Schoepke*
+
 *   `ActiveRecord::Store` works together with PG `hstore` columns.
     Fixes #12452.
 

activerecord/lib/active_record/connection_adapters/postgresql/oid.rb

@@ -249,6 +249,10 @@ def type_cast(value)
         end
 
         class Json < Type
+          def type_cast_for_write(value)
+            ConnectionAdapters::PostgreSQLColumn.json_to_string value
+          end
+
           def type_cast(value)
             return if value.nil?
 

activerecord/test/cases/adapters/postgresql/json_test.rb

@@ -49,6 +49,13 @@ def test_change_table_supports_json
     JsonDataType.reset_column_information
   end
 
+  def test_cast_value_on_write
+    x = JsonDataType.new payload: {"string" => "foo", :symbol => :bar}
+    assert_equal({"string" => "foo", "symbol" => "bar"}, x.payload)
+    x.save
+    assert_equal({"string" => "foo", "symbol" => "bar"}, x.reload.payload)
+  end
+
   def test_type_cast_json
     assert @column