New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG for JSON refactor + added back the `encode_big_decimal_as_string` option with warning #13060

Merged
merged 1 commit into from Dec 3, 2013

Conversation

Projects
None yet
3 participants
@chancancode
Member

chancancode commented Nov 26, 2013

/cc @jeremy

@chancancode chancancode referenced this pull request Nov 26, 2013

Closed

Track rails/rails#13060 #1

@jeremy

View changes

Show outdated Hide outdated activesupport/lib/active_support/json/encoding.rb
@carlosantoniodasilva

View changes

Show outdated Hide outdated activesupport/CHANGELOG.md
@chancancode

View changes

Show outdated Hide outdated activesupport/test/json/encoding_test.rb
@carlosantoniodasilva

View changes

Show outdated Hide outdated activesupport/lib/active_support/json/encoding.rb
@chancancode

This comment has been minimized.

Show comment
Hide comment
@chancancode

chancancode Nov 27, 2013

Member

Updated with the suggestions from @carlosantoniodasilva. I kept the changelog entry in its original position when rebasing, partly because that's the order we merged these commits, and partly because I don't have to compete with future additions to the changelog :)

Member

chancancode commented Nov 27, 2013

Updated with the suggestions from @carlosantoniodasilva. I kept the changelog entry in its original position when rebasing, partly because that's the order we merged these commits, and partly because I don't have to compete with future additions to the changelog :)

@carlosantoniodasilva

View changes

Show outdated Hide outdated activesupport/lib/active_support/json/encoding.rb
@carlosantoniodasilva

View changes

Show outdated Hide outdated activesupport/lib/active_support/json/encoding.rb
@carlosantoniodasilva

View changes

Show outdated Hide outdated activesupport/lib/active_support/json/encoding.rb
@carlosantoniodasilva

View changes

Show outdated Hide outdated activesupport/lib/active_support/json/encoding.rb
@carlosantoniodasilva

This comment has been minimized.

Show comment
Hide comment
@carlosantoniodasilva

carlosantoniodasilva Dec 3, 2013

Member

Minor comment, I think we're good to :shipit:

Member

carlosantoniodasilva commented Dec 3, 2013

Minor comment, I think we're good to :shipit:

@chancancode

This comment has been minimized.

Show comment
Hide comment
@chancancode
Member

chancancode commented Dec 3, 2013

carlosantoniodasilva added a commit that referenced this pull request Dec 3, 2013

Merge pull request #13060 from chancancode/change_log_for_json_refactor
CHANGELOG for JSON refactor + added back the `encode_big_decimal_as_string` option with warning

@carlosantoniodasilva carlosantoniodasilva merged commit 6e905e2 into rails:master Dec 3, 2013

@carlosantoniodasilva

This comment has been minimized.

Show comment
Hide comment
@carlosantoniodasilva

carlosantoniodasilva Dec 3, 2013

Member

Thanks ❤️

Member

carlosantoniodasilva commented Dec 3, 2013

Thanks ❤️

@chancancode

This comment has been minimized.

Show comment
Hide comment
@chancancode

chancancode Dec 3, 2013

Member

😁

Member

chancancode commented Dec 3, 2013

😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment