Skip to content

CHANGELOG for JSON refactor + added back the encode_big_decimal_as_string option with warning#13060

Merged
carlosantoniodasilva merged 1 commit intorails:masterfrom
chancancode:change_log_for_json_refactor
Dec 3, 2013
Merged

CHANGELOG for JSON refactor + added back the encode_big_decimal_as_string option with warning#13060
carlosantoniodasilva merged 1 commit intorails:masterfrom
chancancode:change_log_for_json_refactor

Conversation

@chancancode
Copy link
Copy Markdown
Member

@chancancode chancancode commented Nov 26, 2013

/cc @jeremy

@chancancode chancancode mentioned this pull request Nov 26, 2013
Closed
jeremy
jeremy reviewed Nov 27, 2013
View reviewed changes
Comment thread activesupport/lib/active_support/json/encoding.rb Outdated
Copy link
Copy Markdown
Member

@jeremy jeremy Nov 27, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Copy link
Copy Markdown
Member Author

@chancancode chancancode Nov 27, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, also changed "install the xxx gem" => "add the xxx gem to your Gemfile"

@chancancode
Copy link
Copy Markdown
Member Author

chancancode commented Nov 27, 2013

Updated with the suggestions from @carlosantoniodasilva. I kept the changelog entry in its original position when rebasing, partly because that's the order we merged these commits, and partly because I don't have to compete with future additions to the changelog :)

carlosantoniodasilva
carlosantoniodasilva reviewed Nov 27, 2013
View reviewed changes
Comment thread activesupport/lib/active_support/json/encoding.rb Outdated
Copy link
Copy Markdown
Member

@carlosantoniodasilva carlosantoniodasilva Nov 27, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

encoder (in both messages)

Copy link
Copy Markdown
Member Author

@chancancode chancancode Nov 27, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

carlosantoniodasilva
carlosantoniodasilva reviewed Nov 30, 2013
View reviewed changes
Comment thread activesupport/lib/active_support/json/encoding.rb Outdated
Copy link
Copy Markdown
Member

@carlosantoniodasilva carlosantoniodasilva Nov 30, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be interesting to talk about the gem here too? If people are checking this, they might have a reason for doing so?

Copy link
Copy Markdown
Member Author

@chancancode chancancode Nov 30, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, updated

@chancancode chancancode mentioned this pull request Dec 3, 2013
Merged
carlosantoniodasilva
carlosantoniodasilva reviewed Dec 3, 2013
View reviewed changes
Comment thread activesupport/lib/active_support/json/encoding.rb Outdated
Copy link
Copy Markdown
Member

@carlosantoniodasilva carlosantoniodasilva Dec 3, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If your application depends

@carlosantoniodasilva
Copy link
Copy Markdown
Member

carlosantoniodasilva commented Dec 3, 2013

Minor comment, I think we're good to :shipit:

@chancancode
Copy link
Copy Markdown
Member Author

chancancode commented Dec 3, 2013

@carlosantoniodasilva Fixed 👍

carlosantoniodasilva added a commit that referenced this pull request Dec 3, 2013
@carlosantoniodasilva
Merge pull request #13060 from chancancode/change_log_for_json_refactor
6e905e2 
CHANGELOG for JSON refactor + added back the `encode_big_decimal_as_string` option with warning
@carlosantoniodasilva carlosantoniodasilva merged commit 6e905e2 into rails:master Dec 3, 2013
@carlosantoniodasilva
Copy link
Copy Markdown
Member

carlosantoniodasilva commented Dec 3, 2013

Thanks ❤️

@chancancode
Copy link
Copy Markdown
Member Author

chancancode commented Dec 3, 2013

😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@chancancode @carlosantoniodasilva @jeremy