Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighthouse 3353 #132

Closed
wants to merge 2 commits into from
Closed

Conversation

chielwester
Copy link
Contributor

There was an issue that belongs_to associations with autosave enabled calls save and all callbacks every time the parent record was saved. This results in unexpected behaviour. I've changed this to only call save if the associated record is changed.

…r any nested associations have changed (resolves rails#3353)
@chielwester
Copy link
Contributor Author

I believe this can be pushed to the 3-0-stable branch as well

@joshk
Copy link
Contributor

joshk commented Apr 27, 2011

This looks good, do you test to make sure assocs are not saved if they have not changed?

@chielwester
Copy link
Contributor Author

I added an extra test to check if save is indeed not called when the associated record has not changed.
This pull request is indeed already in master for some time. What should i do to get this in a stable release soon?

@josevalim
Copy link
Contributor

@chielwester Rails 3.1 is getting released soon, so I am closing this issue. When 3.1 is out and you feel you need this on 3-0-stable, please reopen the issue. Thanks for your pull request.

@josevalim josevalim closed this May 7, 2011
vijaydev pushed a commit that referenced this pull request Apr 11, 2013
Fixed an article link at sitepoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants