Make possible rendering of a block with a layout and a collection.

[bughit]

Fixes #13354.

[bughit]

@rafaelfranca

both render_partial and now collection_with_template render the block via view._layout_for which allows the layout to render content_for captures instead of/in addition to the block, by passing a symbol to yield

I am not sure this make sense. In a controller layout scenario the template is rendered first and is therefore able to supply content_for to the layout. Here, the block is rendered on demand, and is not able to supply content to the the layout. So what value does _layout_for provide?

Also the docs already state that the layout is able to pass args to the block, so I guess rendering the block first is not an option.

So perhaps it makes sense to avoid _layout_for for block rendering.

[bughit]

well, there are tests that depend on _layout_for, so never mind

[schneems]

We could make this a bit more readable without sacraficing line count:

args     = {layout: "layouts/yield_with_params", collection: %w[item1 item2], as: :item }
actual   = @view.render(args) do |param, locals|
              "#{param} Content from block! #{locals[:item]}:#{locals[:item_counter]}"
            end
expected = %(Yield! Content from block! item1:0\nYield! Content from block! item2:1\n)
assert_equal expected, actual

[bughit]

this test started as a copy, they all look like this, I think it's readable enough.

[schneems]

It was hard for me to read, even if the others are hard to read no reason we can't make this one better. At the end of the day it won't block the PR but are you happy with the Rails codebase being just good enough ? 😄

[bughit]

going to make a change later, don't merge

[bughit]

I am thinking of the following change:

        content = template.render(view, locals) do |*name|
          if view._yield_to_block?(name.first, @block)
            name << name.extract_options!.merge!(locals)
            view.capture(*name, &@block)
          else
            view._layout_for(*name)
          end
        end

      def _layout_for(*args, &block)
        name = args.first

        if _yield_to_block?(name, block)
          capture(*args, &block)
        else
          super(name)
        end
      end

      def _yield_to_block?(first_yield_arg, block)
        block && !first_yield_arg.is_a?(Symbol)
      end

the idea is to only do locals merging if you know you are going to be capturing the block, but that decision is made in _layout_for, so I factored it out. Should I go with this?

[bughit]

@rafaelfranca can you please review this and the proposed changes above

[bughit]

@rafaelfranca - or suggest someone else

[rafaelfranca]

ack. Assigned to me and I'll take a look tomorrow

[bughit]

@rafaelfranca

[sbonami]

@rafaelfranca I believe this is still an issue. Anything I can do to get this bumped?

[rails-bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.