Be more explicit about the default of db:drop and db:create

[dmathieu]

Closes #13625

[prathamesh-sonpatki]

@dmathieu Can also add this to create task right? rake db:create also creates development and test databases by default right?

[dmathieu]

You're right. Thank you. 🌞

[prathamesh-sonpatki]

@dmathieu I think it can be better worded by
Defaults to creating the development and test databases in absence of Rails.env

[dmathieu]

There never is an absence of Rails.env. It defaults to development.

[prathamesh-sonpatki]

Oops. Yes you are right :)

[prathamesh-sonpatki]

@dmathieu Will it work with [ci skip] ?

[senny]

From the description it's not obvious to me, when the default applies and how I can change it to only create the database of the current Rails.env.

[senny]

Looking closer I think we should also change the functionality. Currently:

• bin/rake db:create => creates dev and test
• RAILS_ENV=development bin/rake db:create => creates dev and test
• RAILS_ENV=test bin/rake db:create => creates test

I think if the RAILS_ENV is specified it should only create the database for that env. This would also allow us to reword the description to:

Create the database from DATABASE_URL or config/database.yml 
for the current RAILS_ENV (use db:create:all to create all databases in the config). 
Without RAILS_ENV it defaults to creating the development and test databases.

This explains when the default is active and how it can be changed.

[senny]

This is even worse when using db:drop. For example:

RAILS_ENV=development bin/rake db:drop will also drop your test database.

[dmathieu]

@senny: your idea definitely makes sense. ⭐
I just pushed it.

[senny]

this is quite hidden. Let's at least add a comment why that check is there.

[dmathieu]

Done.

[senny]

@dmathieu thanks 💛