Adding Hash#compact and Hash#compact! methods #13632
Conversation
|
Not sure. The name seems awkward to me. In my the snippet below is clear about the intention. my_hash.reject! { |_, v| v.nil? }Also, I had a hard time thinking in which cases I'd use this code, and I could not see any usage in regular application. |
|
@rafaelfranca I named as For my usage: def standard_button(text, title=text, disabled_text=nil, class_style='submitForward')
submit_options = :title => title, :class => class_style
submit_options['data-disable-with'] = disabled_text unless disabled_text.nil?
submit_tag text, submit_options
endinstead: def standard_button(text, title=text, disabled_text=nil, class_style='submitForward')
submit_tag text, {:title => title, :class => class_style, 'data-disable-with' => disabled_text}.compact
endyes, I can use |
|
Interesting usage. I think we have some code like this even inside Rails. I'll delegate to @dhh who is better naming things than I 😄 |
|
As a side note, given your use case, Rails has you covered: <%= submit_tag 'zomg', :title => 'title', :class => 'class_style', 'data-disable-with' => nil %>Would output: <input class="class_style" name="commit" title="title" type="submit" value="zomg" />Rails already ignores attributes containing |
|
Nice to know that Rails already ignore nil values for Helpers. |
|
I'm sympathetic to this idea. I even think the name parity with Array#compact makes sense. I do remember writing similar code in the past. So 👍 on name and method from me. |
| class Hash | ||
| # Compact a hash rejecting all nil values | ||
| # | ||
| # hash = { :a => true, :b => false, :c => nil} |
|
Great! Lets get this in. @tinogomes we need to upgrade the active_support guides and we need a CHANGELOG entry. |
| # hash.compact # => { :a => true, :b => false} | ||
| # hash # => { :a => true, :b => false, :c => nil} | ||
| def compact | ||
| self.reject(&reject_nil_values_lambda) |
There was a problem hiding this comment.
You should be able to use dup.compact!, right?
|
@carlosantoniodasilva @rafaelfranca active_support guides and CHANGELOG updated and all your suggestions done! |
| @@ -5,3 +5,4 @@ | |||
| require 'active_support/core_ext/hash/keys' | |||
| require 'active_support/core_ext/hash/reverse_merge' | |||
| require 'active_support/core_ext/hash/slice' | |||
| require 'active_support/core_ext/hash/compact' | |||
There was a problem hiding this comment.
put this in alphabetical order with other requires
|
@egilburg all done! |
| @@ -2907,6 +2907,16 @@ The method `with_indifferent_access` returns an `ActiveSupport::HashWithIndiffer | |||
|
|
|||
| NOTE: Defined in `active_support/core_ext/hash/indifferent_access.rb`. | |||
|
|
|||
| ### Compacting | |||
|
|
|||
| The methods `compact` and `compact!` return an Hash without items with `nil` value. | |||
|
@tinogomes you'll need to squash your commits. |
| # hash # => { a: true, b: false, c: nil} | ||
| # { c: nil }.compact # => {} | ||
| def compact | ||
| self.select { |_, value| !value.nil? } |
There was a problem hiding this comment.
why select here and reject below? We can have the same implementation at both the places?
There was a problem hiding this comment.
Benchmark for better solution:
* Adding Hash#compact and Hash#compact! methods * Using Ruby 1.9 syntax on documentation * Updating guides for `Hash#compact` and `Hash#compact!` methods * Updating CHANGELOG for ActiveSupport * Removing unecessary protected method and lambda for `Hash#compact` implementations * Performing `Hash#compact` implementation - https://gist.github.com/tinogomes/8332883 * fixing order position * Fixing typo
|
squashed! |
Adding Hash#compact and Hash#compact! methods
|
❤️ 💚 💙 💛 💜 |
|
👍 |
Example:
Benchmark for better solution:
https://gist.github.com/tinogomes/8332883