Fix errors for four of the code samples #14313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def save | ||
| @previously_changed = changes | ||
| @changed_attributes.clear |
There was a problem hiding this comment.
you can use changes_applied instead of modifying the instance vars.
There was a problem hiding this comment.
You are correct. As the documentation states, this method should be called after changes are persisted.
|
@m-Peter added a few minor comments, the rest looks good. |
The four code samples that fail to run are: - Add attribute magic to objects. Fixed by introducing a Person instance variable. - Tracking value changes. Fixed by replacing `attr_accessor` with `define_attribute_methods`, providing getter and setter methods for `name` and providing the missing `Person#save` method. A call to `Person#save` has to precede the `person.name = 'robert'` assignment, if we want `previous_changes` to include 'bob'. - Adding `errors` interface to objects. Fixed by introducing a Person instance variable, assigning `nil` to its name and calling `Person#validate!`. - Custom validators. Fixed by defining `HasNameValidator` before it is used by `ValidatorPerson`. All the code samples can now be run smoothly. Call Dirty#changes_applied in Person#save, instead of modifying instance vars.
|
Made the change you proposed and squashed the commits into one, as the Contributing to Ruby on Rails guide suggests. |
senny
added a commit
that referenced
this pull request
Mar 8, 2014
Fix errors for four of the code samples [ci skip]
|
@m-Peter thanks 💛 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The four code samples that fail to run are:
instance variable.
attr_accessorwithdefine_attribute_methods, providing getter and setter methodsfor
nameand providing the missingPerson#savemethod. Acall to
Person#savehas to precede theperson.name = 'robert'assignment, if we want
previous_changesto include 'bob'.errorsinterface to objects. Fixed by introducing aPerson instance variable, assigning
nilto its name and callingPerson#validate!.HasNameValidatorbeforeit is used by
ValidatorPerson.All the code samples can now be run smoothly.