Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect values being printed by assert_select. #14450

Merged
merged 1 commit into from
Mar 23, 2014
Merged

Incorrect values being printed by assert_select. #14450

merged 1 commit into from
Mar 23, 2014

Conversation

vlal-zz
Copy link
Contributor

@vlal-zz vlal-zz commented Mar 22, 2014

Swapped the values so that the correct values are printed

  •      assert_equal matches.size, count, message
    
  •      assert_equal count, matches.size, message
    

* Swapped the paramaters of assert_equal in assert_select so that the
proper values were printed correctly

Fixes #14422
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nitpick but could you add a dot after the issue number please ?

Also the changelog entry should be moved to the very top of the file. Thanks for your contribution so far! :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. I hope that fixed it.

@arthurnn
Copy link
Member

👍

@chancancode
Copy link
Member

Looks good, can you squash the commits into a single one? Should be good to merge after that

@arthurnn
Copy link
Member

Actually you didnt squash them, I guess you can run the follow to acomplish the squash:

git reset --soft 9d44b3f; git commit
git push -f origin HEAD

@vlal-zz
Copy link
Contributor Author

vlal-zz commented Mar 22, 2014

Sorry that was my mistake. I hope this fixes it.

@chancancode
Copy link
Member

Almost ;) Can you git commit --amend and give the commit a better message?

@vlal-zz
Copy link
Contributor Author

vlal-zz commented Mar 22, 2014

Corrected.

chancancode added a commit that referenced this pull request Mar 23, 2014
Incorrect values being printed by assert_select.
@chancancode chancancode merged commit bcf3a82 into rails:master Mar 23, 2014
@chancancode
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants