-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect values being printed by assert_select. #14450
Conversation
* Swapped the paramaters of assert_equal in assert_select so that the | ||
proper values were printed correctly | ||
|
||
Fixes #14422 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nitpick but could you add a dot after the issue number please ?
Also the changelog entry should be moved to the very top of the file. Thanks for your contribution so far! :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem. I hope that fixed it.
👍 |
Looks good, can you squash the commits into a single one? Should be good to merge after that |
Actually you didnt squash them, I guess you can run the follow to acomplish the squash:
|
Sorry that was my mistake. I hope this fixes it. |
Almost ;) Can you |
Corrected. |
Incorrect values being printed by assert_select.
Thanks! |
Swapped the values so that the correct values are printed