Update documentation to use Rails.application instead #14718
Conversation
|
Hello @mcmorgan, Thanks for your contribution. There are other places to update as well which are:
To find these lines I simply rely on the |
|
@robin850 Sure, I will update the other locations and use [ci skip] in the future for documentation changes. |
|
@robin850 The rest of the references to |
| Myapp::Application.config.secret_token = 'existing secret token' | ||
| Myapp::Application.config.secret_key_base = 'new secret key base' | ||
| Rails.application.config.secret_token = 'existing secret token' | ||
| Rails.application.config.secret_key_base = 'new secret key base' |
There was a problem hiding this comment.
I'm not sure that we should update this since it is about Rails 4.0 and Rails.application is favored only since 4.1. Could you please remove this change ?
|
@arthurnn Thank you for this. I was a bit overzealous in my replacements, great catch. I have reverted those unnecessary changes. |
References to ``AppName::Application` removed in favour of ``Rails.application`` as generated with a new rails 4.1 app. [ci skip]
…-generated-config Update documentation to use Rails.application instead
|
@mcmorgan @arthurnn @spastorino : Thanks guys! ❤️ |
References to
AppName::Applicationremoved in favour ofRails.applicationas generated with a new rails 4.1 app.