Move NoTouching down the inheritance chain on AR::Base
#14842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| DeveloperWithTouchCallback.no_touching do | ||
| developer.touch | ||
| assert !developer.after_touch_called |
|
Looks good. Please include a CHANGELOG entry and I'll merge |
| @@ -170,6 +170,15 @@ def test_no_touching_threadsafe | |||
| assert !@developer.no_touching? | |||
| end | |||
|
|
|||
| def test_no_touching_with_callbacks | |||
| developer = DeveloperWithTouchCallback.first | |||
There was a problem hiding this comment.
Can we define DeveloperWithTouchCallback inside this test case?
dev_with_touch_callback = Class.new(ActiveRecord::Base)
# ...
endThis will keep the context together and not increase the global models count any further.
There was a problem hiding this comment.
Sounds good to me. @rafaelfranca thoughts?
…t empty transactions. Closes #14841.
|
@senny @rafaelfranca PR updated 👍 |
senny
added a commit
that referenced
this pull request
Apr 23, 2014
Move `NoTouching` down the inheritance chain on AR::Base
|
@lucasmazza thanks 💛 |
senny
added a commit
that referenced
this pull request
Apr 23, 2014
Move `NoTouching` down the inheritance chain on AR::Base Conflicts: activerecord/test/cases/timestamp_test.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way the
no_touchingblocks won't trigger anytouchrelated callbacks and won't create empty transactions (since it is included after theTransactionsmodule).Fixes #14841.