Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed an issue with migrating legacy json cookies. #14850

Merged
merged 1 commit into from Apr 23, 2014
Merged

Fixed an issue with migrating legacy json cookies. #14850

merged 1 commit into from Apr 23, 2014

Commits on Apr 23, 2014

  1. Fixed an issue with migrating legacy json cookies. 

    Previously, the `VerifyAndUpgradeLegacySignedMessage` assumes all incoming
cookies are marshal-encoded. This is not the case when `secret_token` is
used in conjunction with the `:json` or `:hybrid` serializer.

In those case, when upgrading to use `secret_key_base`, this would cause a
`TypeError: incompatible marshal file format` and a 500 error for the user.

Fixes rails#14774.

*Godfrey Chan*
    @chancancode
    chancancode committed Apr 23, 2014
    Copy the full SHA
    2a412b3 View commit details
    Browse the repository at this point in the history