-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mapper.rb #14915
Update mapper.rb #14915
Conversation
# | ||
# Since Rails 4, you should not use the `match` method in your router |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets not talk about version here. I think we can remove the Since Rails 4,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense.
@juanpastas can you make the commit short message a little more descriptive? |
Also , for doc changes we try to add a |
Thanks. |
(also make sure to squash your commits in one) |
squashed. |
Update mapper.rb [ci skip]
Update mapper.rb [ci skip] Conflicts: actionpack/lib/action_dispatch/routing/mapper.rb
Required
via
option inmatch
method.