Keep column defaults in type cast form #15492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The contract of `_field_changed?` assumes that the old value is always type cast. That is not the case for the value in `Column#default` as things are today. It appears there are other public methods that assume that `Column#default` is type cast, as well. The reason for this change originally was because the value gets put into `@raw_attributes` in initialize. This reverts to the old behavior on `Column`, and updates `initialize` to make sure that the values are in the right format.
sgrif
referenced
this pull request
Jun 3, 2014
That data is internal to Active Record. What we care about is that new records have the right default value.
senny
added a commit
that referenced
this pull request
Jun 3, 2014
…fault`." Revert "test pg, remove unused column assignments. Follow up to 254cdf4" Related to #15492 This reverts commit 254cdf4. This reverts commit 4bcf902. There are public methods that assume `Column#default` is type casted. The return value of `Column#default` is publicly relevant and should not change. /cc @sgrif
rafaelfranca
added a commit
that referenced
this pull request
Jun 3, 2014
Keep column defaults in type cast form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The contract of
_field_changed?assumes that the old value is alwaystype cast. That is not the case for the value in
Column#defaultasthings are today. It appears there are other public methods that
assume that
Column#defaultis type cast, as well. The reason for thischange originally was because the value gets put into
@raw_attributesin initialize. This reverts to the old behavior on
Column, and updatesinitializeto make sure that the values are in the right format.