Don't use transactions when working with unsafed records in associations #1601
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently rails wraps every operation on association collections in a transaction. This results in unecessary
BEGIN
COMMIT
statements sent to the database server when working with unsaved records. In our application these unecessary statements caused about 70% of the whole database time.Example:
The same issue applies not only to
CollectionAssociation#concat
but also toCollectionAssociation#replace
andCollectionAssociation#delete_or_destroy
. This pull request fixes the issue by only wrapping the calls when the transaction is actually needed.