Remove unneccessary special case for money in quoting #16037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are broken |
|
Updated |
| @@ -45,14 +45,6 @@ def test_quote_float_infinity | |||
| assert_equal "'Infinity'", @conn.quote(infinity, c) | |||
| end | |||
|
|
|||
| def test_quote_cast_numeric | |||
| fixnum = 666 | |||
There was a problem hiding this comment.
Removing this test doesn't mean that now integer are not being quoted when the column type is a string? I guess this would cause an SQL error. Does we have tests to ensure it is working?
There was a problem hiding this comment.
No, I don't think there's a test for this. It's perfectly valid to provide a number for a string column, so I felt like we would be testing PG not Rails. I'll provide a test if you think we should, though.
There was a problem hiding this comment.
hmm, if it is perfect valid why we were quoting? I think is better to add a test to make sure it works.
There was a problem hiding this comment.
No clue why were quoting. I'll add a test...
|
This should be good, now. |
rafaelfranca
added a commit
that referenced
this pull request
Jul 4, 2014
Remove unneccessary special case for money in quoting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.